[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

Wed Sep 22 11:03:25 PDT 2021

MaskRay added a comment.

In D97572#3015920 <https://reviews.llvm.org/D97572#3015920>, @nickdesaulniers wrote:

> Hi, I'm hacking on trying to bootstrap a build of clang from sources linked against musl.  I'm hitting a curious set of failures trying to bootstrap libcxxabi:
>
>   llvm-project/libcxx/include/__config:13:10: fatal error: '__config_site' file not found
>   #include <__config_site>
>
> @compnerd mentioned this commit.  It no longer can be reverted cleanly, but if I check out the commit before this, I no longer have this error bootstrapping.
>
> (This isn't necessarily a regression; my scripts never worked on the first place.  I only started writing them recently; much later than when this landed.  That said, bootstrapping seems a bit trick at the moment and it's not clear how to fix).

`include/__config` includes the generated `include/x86_64-unknown-linux-gnu/c++/v1/__config_site`.
`__config_site` has target specific customization.
`clang --target=xxx` using `include/yyy/c++/v1/__config_site` does not guarantee to work.

In practice, we can think that xxx and yyy may be similar enough and it may work if you just copy `include/yyy/c++/v1/__config_site` to `include/xxx/c++/v1/__config_site`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572