[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

[Bjorn Pettersson via Phabricator via libcxx-commits]

bjope added a comment.

In D97572#3015742 <https://reviews.llvm.org/D97572#3015742>, @ldionne wrote:

> Agreed with @phosek and @mstorsjo. Also, I looked at `ppc-xmmintrin.c` and traced down the includes, and I don't see what would cause this issue. @bjope if you'd like to try to `-DCLANG_DEFAULT_CXX_STDLIB=libc++` again, I'll do my best to help you troubleshoot the issue. If you do, it's easiest to reach out to me on Discord in the #libcxx channel.

I actually started out by complaining about the test case here https://reviews.llvm.org/D103386#2790821 but I don't think it was corrected.

So that was one of the reasons for starting to ask questions in this review.

But I also wanted to know how this is supposed to work (or what shouldn't work) in a broader perspective. And there was also this other scenario that isn't helped out by adjusting a lit test in the llvm-project repo:

> Another problem is that a user was using my clang build together with "--target=x86_64-wrs-linux". This has worked fine in the past, but now when we only get "include/x86_64-unknown-linux-gnu/c++/v1/__config_site" in the compiler-clang install the user get failures about not finding __config_site. I could mention that this user is not even interested in linking the program, just using clang for static analysis. But the conclusion is that even for doing static analysis one need to match the target with one of the targets for which we have built libcxx. Maybe this is as expected? Or maybe it has been forseen?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572