[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D97572#3015537 <https://reviews.llvm.org/D97572#3015537>, @mstorsjo wrote:

> In D97572#3015517 <https://reviews.llvm.org/D97572#3015517>, @bjope wrote:
>
>> If I recall correctly one of the problems that we started to see with this commit was that the test case `clang/test/CodeGen/ppc-xmmintrin.c` started to fail. That is the test case that is using `powerpc64le-unknown-linux-gnu`, and that would fail with `fatal error: '__config_site' file not found`.
>> So we could not use `ninja check-all` with that build setup.
>>
>> Our current "workaround" is to avoid using `-DCLANG_DEFAULT_CXX_STDLIB=libc++`. So we kind of postponed the idea of building the compiler with `libc++`.
>
> That sounds to me like that testcase needs to be adjusted so that it's not reliant on the surrounding setup - the clang tests shouldn't rely on clang itself having a working C++ standard library available at all, in general.

I agree, that looks like an issue with the test that should be addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572