[libcxx-commits] [libcxx] 5efafc3 - Revert "[libcxx][pretty printers] Import gdb module in gdb feature check"
David Spickett via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Sep 24 02:13:11 PDT 2021
Author: David Spickett
Date: 2021-09-24T09:11:28Z
New Revision: 5efafc3e65c52effeefa84385bc9d8b7eb0d3291
URL: https://github.com/llvm/llvm-project/commit/5efafc3e65c52effeefa84385bc9d8b7eb0d3291
DIFF: https://github.com/llvm/llvm-project/commit/5efafc3e65c52effeefa84385bc9d8b7eb0d3291.diff
LOG: Revert "[libcxx][pretty printers] Import gdb module in gdb feature check"
This reverts commit 0c2a4548455c6c943ac5e2b5c51ed5c2c91e34e7.
This was my mistake. When gdb can find its data directory it'll
import it automatically. If it can't (like when you're using a
version from a build folder) you need to give it the data
directory path.
We're safe to assume gdb is installed for testing purposes
so it'll import it for us.
Added:
Modified:
libcxx/utils/libcxx/test/features.py
Removed:
################################################################################
diff --git a/libcxx/utils/libcxx/test/features.py b/libcxx/utils/libcxx/test/features.py
index ec4850207f524..1204304899120 100644
--- a/libcxx/utils/libcxx/test/features.py
+++ b/libcxx/utils/libcxx/test/features.py
@@ -171,7 +171,6 @@ def check_gdb(cfg):
# Using the quit command here means that gdb itself exits, not just
# the "python <...>" command.
test_src = """\
-import gdb
try:
gdb.Breakpoint(\"main\").commands=\"foo\"
except AttributeError:
More information about the libcxx-commits
mailing list