[libcxx-commits] [PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D109408#2996128 <https://reviews.llvm.org/D109408#2996128>, @zhouyizhou wrote:

> In D109408#2996092 <https://reviews.llvm.org/D109408#2996092>, @Quuxplusone wrote:
>
>> I was going to land this just now, but then realized that I've lost the thread of why we're doing most of this. Why are we touching clang/test/SemaCXX/? So I'm going to land just the fixing of the curly braces in libcxxabi/src/.
>
> Hi, 
> Very sorry to bring you so much trouble. 
> I am new to LLVM, and I am only intend to fix the curly braces in libcxxabi/src/,
> I followed https://www.llvm.org/docs/Phabricator.html#phabricator-reviews to make a patch using: 
> git diff -U999999 u <https://reviews.llvm.org/diviner/find/?name=u&type=null&jump=1> > /tmp/mypatch.patch
> I am also very confused why clang/test/SemaCXX/ appears in mypatch.patch.
> Sorry again.
> And thanks for landing the fixing of  the curly braces in libcxxabi/src/ for me.
>
> Zhouyi

When you submit patches, please follow https://libcxx.llvm.org/Contributing.html. In particular, you should follow these instructions for submitting using `arc diff` -- it works a lot better than the web interface: https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line.

Thanks for the patch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109408/new/

https://reviews.llvm.org/D109408