[libcxx-commits] [PATCH] D110347: [libc++] Do not enable P1951 before C++23, since it's a breaking change

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: rsmith.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

In reaction to the issues raised by Richard in https://llvm.org/D109066,
this commit does not apply P1951 <https://reviews.llvm.org/P1951> as a DR in previous standard modes,
since it breaks valid code.

I do believe it should be applied as a DR, however ideally we'd get some
sort of statement from the Committee to this effect (and all implementations
would behave consistently). In the meantime, only implement P1951 <https://reviews.llvm.org/P1951> starting
with C++23 -- we can always come back and apply it as a DR if that's what
the Committee says.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110347

Files:
  libcxx/include/__utility/pair.h
  libcxx/test/std/utilities/utility/pairs/pairs.pair/U_V.pass.cpp
  libcxx/test/std/utilities/utility/pairs/pairs.pair/ctor.brace-init.P1951.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110347.374599.patch
Type: text/x-patch
Size: 4492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210923/36395925/attachment.bin>