[libcxx-commits] [PATCH] D110110: [libc++] [ABI BREAK] Remove non-atomic "platform" semaphore implementations.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 23 08:48:15 PDT 2021


ldionne added a subscriber: wash.
ldionne added a comment.

On the one hand, the platform semaphore is going to work better because it uses the OS primitives, so that will respect whatever implementation is preferred on the OS. On the other hand, I find it surprising that the constructor is marked as `constexpr` if that can't be implemented using the most common implementation, i.e. pthread's `sem_init`. I'd like to see what @__simt__ or @wash  have to say about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110110/new/

https://reviews.llvm.org/D110110



More information about the libcxx-commits mailing list