[libcxx-commits] [PATCH] D110334: [libcxx][pretty printers] Check GDB Python scripting support

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 23 07:53:31 PDT 2021


ldionne added a comment.

So IIUC, the test was being run before 8.3, but it would fail silently? That's pretty bad.



================
Comment at: libcxx/utils/libcxx/test/features.py:13
 import sys
+from subprocess import check_output, CalledProcessError, DEVNULL
 
----------------
Please just `import subprocess` and then qualify names below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110334/new/

https://reviews.llvm.org/D110334



More information about the libcxx-commits mailing list