[libcxx-commits] [PATCH] D110285: [libc++] Use CMake interface targets to setup benchmark flags

Wed Sep 22 13:45:07 PDT 2021

jloser added inline comments.

================
Comment at: libcxx/benchmarks/CMakeLists.txt:100
+  if (LIBSTDCXX_FILESYSTEM_TEST)
+    target_link_libraries(cxx-benchmarks-flags-native INTERFACE "-lstdc++fs")
+  endif()
----------------
ldionne wrote:
> jloser wrote:
> > Nit: are we consistent whether to quote arguments or not? For example, below we say `-lc++fs -lc++experimental`, i.e. unquoted, but here we quote `"-lstdc++fs"`. I'd like to be consistent at least within this neighborhood of code; I don't feel strongly on either way.
> Agreed, I'll unquote. Thanks for noticing. However, that makes me notice that I wasn't quoting the paths in other places, and we definitely want to do that in case they contain spaces.
Makes sense. Yeah, we definitely want to quote paths.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110285/new/

https://reviews.llvm.org/D110285