[libcxx-commits] [PATCH] D107721: [libc++][spaceship] Implement std::pair::operator<=>

[Kent Ross via Phabricator via libcxx-commits]

mumbleskates added inline comments.


================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.spec/three_way_comparison.pass.cpp:15
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17, libcpp-no-concepts
+
----------------
Mordante wrote:
> We normally start with this line, can you move it above `// <utility>`?
That hasn't been my observation, all the adjacent tests (for tuple, for example) already have this line at the end where it is here. I put it where it is to match surrounding code. Grepping around the rest of the project shows no consistency at all in its placement so I'd like to prefer just matching the adjacent files.


================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.spec/three_way_comparison.pass.cpp:96
+
+  // GCC cannot evaluate NaN @ non-NaN constexpr, so test that runtime-only.
+  {
----------------
Mordante wrote:
> How do you feel about this work-around and move these two tests back in `test()`?
> When you do that make sure to start a CI run before committing.
Yeah that looks good, I'll make the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107721/new/

https://reviews.llvm.org/D107721