[libcxx-commits] [PATCH] D110284: [libc++] Remove uses of _LIBCPP_HAS_NO_VARIABLE_TEMPLATES

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 22 13:25:27 PDT 2021


ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/selftest/test_macros.pass.cpp:33
 
 void test_libcxx_macros()
 {
----------------
jloser wrote:
> Now that this function is empty, can we just remove it and its call site in `main` below?
I was going to leave it as-is in case we re-add some in the future, but yeah, I agree with you. I'll remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110284/new/

https://reviews.llvm.org/D110284



More information about the libcxx-commits mailing list