[libcxx-commits] [PATCH] D110198: [libc++] Fix __wrap_iter to be a proper contiguous iterator.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

LGTM with include fixes and green CI!



================
Comment at: libcxx/test/std/utilities/memory/pointer.conversion/to_address_std_iterators.pass.cpp:13-16
-// TODO: We should enable this test in Debug mode once we fix __wrap_iter
-//       to be a proper contiguous_iterator.
-// UNSUPPORTED: LIBCXX-DEBUG-FIXME
-
----------------
Quuxplusone wrote:
> @ldionne wrote:
> > also I'd like to have a test that exercises std::to_address for a __wrap_iter.
> 
> That's what this is... and now it passes in debug mode too. :)  This suffices, right?
Oh, sorry, yeah. Went too fast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110198/new/

https://reviews.llvm.org/D110198