[libcxx-commits] [PATCH] D110198: [libc++] Fix __wrap_iter to be a proper contiguous iterator.
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Sep 22 11:21:42 PDT 2021
Quuxplusone marked 3 inline comments as done.
Quuxplusone added inline comments.
================
Comment at: libcxx/test/std/utilities/memory/pointer.traits/pointer_to.pass.cpp:20-23
+#include <string>
+#include <string_view>
+#include <vector>
+
----------------
ldionne wrote:
> Why those includes?
Oops. I had originally added some test cases here for `pointer_traits<std::vector<int>::iterator>::pointer_to` etc., before eventually realizing "oh yeah, that'll never work." And then I reverted that part of the file, but forgot to revert the includes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110198/new/
https://reviews.llvm.org/D110198
More information about the libcxx-commits
mailing list