[libcxx-commits] [PATCH] D109593: WIP: [libcxx] Add a CI configuration for standalone building in llvm-project/runtimes

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D109593#3012195 <https://reviews.llvm.org/D109593#3012195>, @mstorsjo wrote:

> @phosek - What do you think of the rest of the changes left here in this patch now - do they seem sensible? Should I split them out to one to three more individual changes for the runtimes build (moving setting `LLVM_RUNTIMES_BUILD` to llvm/runtimes, including llvm-lit when necessary, making sure `LLVM_INCLUDE_TESTS` is on by default)?

The increased use of `LLVM_RUNTIMES_BUILD` concerns me a bit. That variable was always meant to be a short term hack to work around the issue with the compiler-rt build, see https://github.com/llvm/llvm-project/blob/47f79c6057764e0c83016269ae2359f8c5c8d135/runtimes/CMakeLists.txt#L134. I should have probably used a more ominous name like `DONT_USE_THIS_COMPILER_RT_BUILD_NEEDS_FIXING` to make it more clear.



================
Comment at: runtimes/CMakeLists.txt:190-192
+    # If built by manually invoking cmake on this directory, we don't have
+    # llvm-lit. If invoked via llvm/runtimes, this is already set up at that
+    # level.
----------------
Could avoid the llvm-lit setup in llvm/runtimes and always do it here unconditionally?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109593/new/

https://reviews.llvm.org/D109593