[libcxx-commits] [PATCH] D109668: [libc++][test] Fix iterator assertion in span.cons/deduct.pass.cpp

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

In D109668#3010463 <https://reviews.llvm.org/D109668#3010463>, @ldionne wrote:

> LGTM but we must fix the Debug mode CI!

I dug into it for a bit, but I'm not sure how to fix it. The problem is from the statement `std::to_address(str.end())`. What we want to happen is `str.end()` to return the wrapped iterator and then pick up the `std::to_address` defined for wrapped iterators (so it calls its `base()` function). I don't know why this fires the asserts in `__iterator/wrap_iter:95`. Since the problem seems mostly unrelated to what the intent of the fix was in this patch, I recommend we fix it in a follow-up if @ldionne or @Quuxplusone know what's wrong. So, I brought back the `std::equal` call for the `std::string` and `const std::string` tests.

Let me know what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109668/new/

https://reviews.llvm.org/D109668