[libcxx-commits] [PATCH] D110088: [libcxxabi] Make InitByteGlobalMutex check GetThreadID instead of PlatformThreadID

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 20 14:02:24 PDT 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Can you quickly explain why this is going to simplify your life in the other patches? Without knowing more about your motivations, I would say that `PlatformSupportsThreadID()` provides more information to the reader than testing `PlatfromThreadID != nullptr`, so I'd be tempted to think it's a useful abstraction to keep. Why are you removing it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110088/new/

https://reviews.llvm.org/D110088



More information about the libcxx-commits mailing list