[libcxx-commits] [PATCH] D110097: [NFC][libcxxabi] In cxa_guard, add a dedicated base class for the Guard classes.

Daniel McIntosh via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 20 12:29:48 PDT 2021


DanielMcIntosh-IBM created this revision.
DanielMcIntosh-IBM added reviewers: ldionne, EricWF.
DanielMcIntosh-IBM requested review of this revision.
Herald added a project: libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++abi.

This moves all of the common work such as splitting up the raw guard
object out of the individual Guard classes. In the process we also
update the signature of the InitByteNoThreads constructor to match the
others.

While the Guard classes already all inherited from the GuardObject
class, we want that to focus on managing reads/writes to the guard byte
(and thus we renamed GuardObject to GuardByte).

This is the 4th of 5 changes to overhaul cxa_guard.
See D108343 <https://reviews.llvm.org/D108343> for what the final result will be and more details on why
cxa_guard is getting overhauled.

Depends on D110093 <https://reviews.llvm.org/D110093>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110097

Files:
  libcxxabi/src/cxa_guard_impl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110097.373690.patch
Type: text/x-patch
Size: 6067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210920/778220f3/attachment.bin>


More information about the libcxx-commits mailing list