[libcxx-commits] [PATCH] D109942: Eliminate _LIBCPP_EQUAL_DELETE in favor of `=delete`. NFC.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 20 10:32:30 PDT 2021


Quuxplusone added a comment.

In D109942#3009825 <https://reviews.llvm.org/D109942#3009825>, @ldionne wrote:

> I think there are similar simplifications we can make to the test suite.

I didn't immediately see anything related to `=delete` in the tests. They may have been dealt with already, I guess.

For the record: I //do// see a similar macro `_LIBCPP_DEFAULT` in `<__config>`, but it is not as mechanical to remove, because its semantics are "Make things defaulted (possibly trivial) in C++11, non-defaulted (non-trivial) in C++03." And it is used only in `atomic`, `std::allocator` (where ISTR we have needed discussions to //avoid// exactly that kind of ABI break), and `error_category` (where it is guarded by some dylib-related stuff that is beyond me). So I am //not// planning a followup patch to remove `_LIBCPP_DEFAULT`, myself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109942/new/

https://reviews.llvm.org/D109942



More information about the libcxx-commits mailing list