[libcxx-commits] [PATCH] D110042: [libc++] counting_semaphore should not be default-constructible

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Sep 19 13:57:46 PDT 2021


Quuxplusone updated this revision to Diff 373476.
Quuxplusone added a comment.

Remove `constexpr` from the "bad" semaphore_base implementation; leave it on `counting_semaphore`'s public API, for the benefit of platforms already using the atomic_base implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110042/new/

https://reviews.llvm.org/D110042

Files:
  libcxx/include/semaphore
  libcxx/test/std/thread/thread.semaphore/binary.pass.cpp
  libcxx/test/std/thread/thread.semaphore/ctor.compile.pass.cpp
  libcxx/test/std/thread/thread.semaphore/max.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110042.373476.patch
Type: text/x-patch
Size: 4106 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210919/a579ce03/attachment.bin>


More information about the libcxx-commits mailing list