[libcxx-commits] [PATCH] D110042: [libc++] counting_semaphore should not be default-constructible

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, libc++, __simt__.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

  Neither the current C++2b draft, nor any revision of [p1135],
  nor libstdc++, claims that `counting_semaphore` should be
  default-constructible. I think this was just a copy-paste issue
  somehow.
  
  Also, `explicit` was missing from the constructor.
  
  Also, `constexpr` was missing; but that's probably more of a
  technical limitation, since apparently there are some platforms
  where we don't (can't??) use the atomic implementation and
  have to rely on pthreads, which obviously isn't constexpr.
  Let's see what buildkite thinks of the `constexpr` keyword here.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D110042

Files:
  libcxx/include/semaphore
  libcxx/test/std/thread/thread.semaphore/binary.pass.cpp
  libcxx/test/std/thread/thread.semaphore/ctor.compile.pass.cpp
  libcxx/test/std/thread/thread.semaphore/max.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110042.373472.patch
Type: text/x-patch
Size: 3978 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210919/ef5112f3/attachment.bin>