[libcxx-commits] [PATCH] D108394: add tsan shared library

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.


================
Comment at: compiler-rt/test/tsan/CMakeLists.txt:108
   DEPENDS ${TSAN_TEST_DEPS})
 set_target_properties(check-tsan PROPERTIES FOLDER "Compiler-RT Tests")
+
----------------
Nothing sets COMPILER_RT_TSAN_HAS_DYNAMIC_RUNTIME variable?

I guess you need to follow COMPILER_RT_ASAN_HAS_STATIC_RUNTIME
Name is weird but I believe it means that if !COMPILER_RT_ASAN_HAS_STATIC_RUNTIME then dynamic is default.
if COMPILER_RT_ASAN_HAS_STATIC_RUNTIME, static is default and we need to do additional dirs/configs to test dynamic stuff. I guess it applies to TSAN as well, so it would be nice if we replicate same approach here for consistency.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394