[libcxx-commits] [PATCH] D109711: [libc++][test] Remove disable_missing_braces_warning.h from few tests

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

> @Quuxplusone Am I missing something? AFAIK `const std::array<long, 5> arr = {4, 5, 6, 7, 8};` is valid C++11.

It's definitely //valid//, but I had assumed (wrongly, it seems) that it would still trigger a //non-fatal warning// on Clang and/or GCC, which would have been the point of the header: to avoid that non-fatal warning.
//However//, at least on Godbolt,

- I cannot reproduce any such warning on Clang at all
- I can reproduce it on GCC but only by //explicitly passing// `-Wmissing-braces`; it's not part of `-Wall -Wextra`

So yeah, @jloser, can we see what happens if you just `git rm disable_missing_braces_warning.h` and remove all its uses? I now predict that we'll see buildkite totally happy with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109711/new/

https://reviews.llvm.org/D109711