[libcxx-commits] [PATCH] D109711: [libc++][test] Remove disable_missing_braces_warning.h from few tests

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

If buildkite is actually OK with this, then I'm OK with it.

But I assume that buildkite would //not// be OK with this as-is; I assume it'll produce that warning diagnostic. But I think we should fix the warning appropriately, e.g. by changing `const std::array<long, 5> arr = {4, 5, 6, 7, 8};` to `const std::array<long, 5> arr = {{4, 5, 6, 7, 8}};`. I believe such changes will be trivially easy, //except// for `apply_extended_types.pass.cpp`, where the missing braces are inside a template that's used sometimes with `array` (which needs double braces) and sometimes with `tuple` (which needs single braces).

I don't understand why you changed only these few tests. E.g. why not any of the tests under `std/containers/sequences/array/`? and why not `std/iterators/iterator.range/begin-end.pass.cpp`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109711/new/

https://reviews.llvm.org/D109711