[libcxx-commits] [PATCH] D109668: [libc++][test] Fix iterator assertion in span.cons/deduct.pass.cpp

Mon Sep 13 08:31:27 PDT 2021

jloser added inline comments.

================
Comment at: libcxx/test/std/containers/views/span.cons/deduct.pass.cpp:26
 //   template<class Container>
 //     span(const Container&) -> span<const typename Container::value_type>;

----------------
Quuxplusone wrote:
> cppreference says: https://en.cppreference.com/w/cpp/container/span/deduction_guides
I agree that's where we'll get to. This was noticed as I was working on P1394 (https://wg21.link/p1394) which removes these container/const container deduction guides (and constructors) in favor of just a range constructor. So, the comment in the deduction test is fine/correct given the current implementation of `span` in libc++.

I'll clean up the other parts of the rest per your comments in this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109668/new/

https://reviews.llvm.org/D109668