[libcxx-commits] [PATCH] D107895: [runtimes] Set more paths when building runtimes standalone

Fri Sep 10 01:21:52 PDT 2021

mstorsjo added a comment.

In D107895#2993732 <https://reviews.llvm.org/D107895#2993732>, @phosek wrote:

> In D107895#2993635 <https://reviews.llvm.org/D107895#2993635>, @mstorsjo wrote:
>
>> Did that setup work for you before I landed the original version of this patch (when nothing was set) or is it just that my patch didn't quite work as intended?
>
> It did, I looked into it and it's because before the build would take this branch https://github.com/llvm/llvm-project/blob/4f9217c5194b10f8219613506f8d701a24650bbc/libcxx/CMakeLists.txt#L439 and `CMAKE_BINARY_DIR` would be set whereas now it takes https://github.com/llvm/llvm-project/blob/4f9217c5194b10f8219613506f8d701a24650bbc/libcxx/CMakeLists.txt#L427 and `LLVM_BINARY_DIR` is unset.

Oh, that explains it indeed. Thanks for the fix, and sorry for not getting it right on the reland!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107895/new/

https://reviews.llvm.org/D107895