[libcxx-commits] [PATCH] D107895: [runtimes] Set more paths when building runtimes standalone

Fri Sep 10 00:45:57 PDT 2021

mstorsjo added a comment.

In D107895#2993564 <https://reviews.llvm.org/D107895#2993564>, @phosek wrote:

> We're still seeing issue on our bots even after reland. This is the standalone build of libc++ on macOS when targeting Apple Silicon when we use `runtimes/CMakeLists.txt` as the top-level file. The error is:
>
>   CMake Error: Could not open file for write in copy operation /include/c++/v1/__config_site.tmp
>   CMake Error: : System Error: No such file or directory
>   CMake Error at /Users/phosek/llvm/llvm-project/libcxx/include/CMakeLists.txt:436 (configure_file):
>     configure_file Problem configuring file
>
> I debugged this and it looks the problem is that in this case `LLVM_BINARY_DIR` is unset and so https://github.com/llvm/llvm-project/blob/704a39569346401e96a6a3978ddc490dfa828ccc/runtimes/CMakeLists.txt#L64 fails.
>
> Replacing that check:
>
>   if (NOT LLVM_BINARY_DIR)
>
> seems to be working.

Did that setup work for you before I landed the original version of this patch (when nothing was set) or is it just that my patch didn't quite work as intended?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107895/new/

https://reviews.llvm.org/D107895