[libcxx-commits] [PATCH] D109056: [libc++] Reject volatile types in std::allocator

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 9 12:08:00 PDT 2021


jloser added a comment.

We have some tests that show we can use `std::make_shared<T>` when `T` is volatile type (see `make_shared.volatile.pass.cpp`).  If we want this to work still, we can't have the `static_assert` in `std::allocator`.

@ldionne do you still think we should reject `volatile` types in `std::allocator`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109056/new/

https://reviews.llvm.org/D109056



More information about the libcxx-commits mailing list