[libcxx-commits] [PATCH] D109066: [libc++] Implement P1951, default arguments for pair's forwarding constructor

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D109066#2983114 <https://reviews.llvm.org/D109066#2983114>, @Quuxplusone wrote:

>> I mean the code previously would work just as well, but it would make a copy instead by using the `pair(T1 const&, T2 const&)` ctor.
>
> Well, now I'm even //less// sure I understand the procedural issues here. [...]

Hmm, indeed, your point of view makes sense. Since the brace-init bits should always have worked, I added tests for those in all standard modes (except C++03, but whatever). Then, I added tests for just https://wg21.link/P1951 in C++23 and above (and on libc++ in all std modes as an extension).

Regarding the GCC issue, I filed a bug here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102247. I'll mark the test as XFAIL on GCC for now, and I'll revisit the test once I have more information.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109066/new/

https://reviews.llvm.org/D109066