[libcxx-commits] [PATCH] D109459: [libc++][ABI BREAK] Remove the C++03 emulation for std::nullptr_t

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

FWLIW, I'm generally in favor of this. Although I think it's ironic that we //already had// an ABI flag for this, such that we'd have gotten this change for free if we ever managed to reach ABIv2. Feels like this PR is the most public admission yet that we'll never actually be able to reach `std::__2`.



================
Comment at: libcxx/include/cstddef:46
 
+using ::nullptr_t _LIBCPP_USING_IF_EXISTS;
 using ::ptrdiff_t _LIBCPP_USING_IF_EXISTS;
----------------
Surely this should just unconditionally say `typedef decltype(nullptr) nullptr_t;` — why would we ever //not// want `std::nullptr_t` to exist?
(Vice versa, personally I don't understand why we define a type named `::nullptr_t`; but I assume there's some good reason not to remove it now.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109459/new/

https://reviews.llvm.org/D109459