[libcxx-commits] [PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

[zhouyizhou via Phabricator via libcxx-commits]

zhouyizhou added a comment.

In D109408#2988417 <https://reviews.llvm.org/D109408#2988417>, @ldionne wrote:

> FWIW, I dislike that we don't indent stuff at all inside namespaces -- often I find it useful to indent things inside short-lived namespaces. But let's go for simplicity and consistency.
>
> Did you look into clang-formatting other files in libc++abi? What would the diff look like?

Thanks for reviewing,
I will look into other files in libc++abi one by one, and report what I have found ;-)
Thanks again
Zhouyi



================
Comment at: libcxxabi/src/cxa_exception_storage.cpp:102
 }
 }
+} // namespace __cxxabiv1
----------------
Quuxplusone wrote:
> LGTM, FWIW.
> 
> It's surprising that clang-format adds `} // namespace foo` closing comments, but doesn't add `} // extern "C"` closing comments: this lonely brace is a bit confusing and I think it //would// benefit from an `// extern "C"` comment.
Thanks for reviewing, 
clang-format do behave a little strange to me. The result of invoking clang-format in git cloned directory is diffent from invoking clang-format in other directory ( for example /tmp).
By the way, I have not write access to LLVM, so I need someone to commit for me.

Thanks again ;-)
Zhouyi


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109408/new/

https://reviews.llvm.org/D109408