[libcxx-commits] [PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Sep 7 18:30:44 PDT 2021
Quuxplusone added inline comments.
================
Comment at: libcxxabi/src/cxa_exception_storage.cpp:102
}
}
+} // namespace __cxxabiv1
----------------
LGTM, FWIW.
It's surprising that clang-format adds `} // namespace foo` closing comments, but doesn't add `} // extern "C"` closing comments: this lonely brace is a bit confusing and I think it //would// benefit from an `// extern "C"` comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109408/new/
https://reviews.llvm.org/D109408
More information about the libcxx-commits
mailing list