[libcxx-commits] [PATCH] D108394: add tsan shared library

[Evgenii Stepanov via Phabricator via libcxx-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/tsan/CMakeLists.txt:266
                                        clang_rt.tsan_cxx-${arch})
+    add_compiler_rt_runtime(clang_rt.tsan
+      SHARED
----------------
vitalybuka wrote:
> @eugenis I would say that we need to test dynamic runtime, but I noticed that we test Asan but don't hwasan and ubsan. Is there good reason for that or just overlook?
We test hwasan on android, it defaults to shared runtime there. As well as all sanitizers, I believe.

Yeah, it would be good to add such testing.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108394/new/

https://reviews.llvm.org/D108394