[libcxx-commits] [PATCH] D109056: [libc++][docs] Mark LWG 2447 as incomplete

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 7 13:15:27 PDT 2021


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Instead, would it be possible to add a `static_assert` in `std::allocator` that we're not passing a volatile type, and leave this as completed? Technically, I think this requires no change at all (and so we are correct in saying that we implement it) since the program is free to be ill-formed if one passes a volatile type to `std::allocator` (well, the resulting `std::allocator<T>` is not required to be a `Cpp17Allocator`). But I think it's good to explicitly error-out.

We could also add a libc++ specific test for that behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109056/new/

https://reviews.llvm.org/D109056



More information about the libcxx-commits mailing list