[libcxx-commits] [PATCH] D108080: [libcxx] simplifies nodiscard by permanently enabling the attribute...

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for running this test!
It would still be nice to see whether @cjdb's results match with your results and the feedback of Microsoft. (Unless that's a lot of effort.)

I think this is a good way forward. Let's make sure we update the release notes in this patch.
I think it would be nice to issue a diagnostic when the user turns on the knob, that way they know it's only a temporary solution; the real solution is to fix their code.

A transition period of a year sounds reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108080/new/

https://reviews.llvm.org/D108080