[libcxx-commits] [PATCH] D109342: [libcxx][libcxxabi] CMAKE_REQUIRED_FLAGS is a string, not a list

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/cmake/config-ix.cmake:43
     find_compiler_rt_library(builtins LIBCXX_BUILTINS_LIBRARY)
-    list(APPEND CMAKE_REQUIRED_LIBRARIES "${LIBCXX_BUILTINS_LIBRARY}")
+    set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${LIBCXX_BUILTINS_LIBRARY}")
   elseif (LIBCXX_HAS_GCC_LIB)
----------------
This is changing the behavior.  `CMAKE_REQUIRED_LIBRARIES` was being set here previously and that is correct.  Unlike `CMAKE_REQUIRED_FLAGS`, that is a `;` delimited list.


================
Comment at: libcxxabi/cmake/config-ix.cmake:33
     find_compiler_rt_library(builtins LIBCXXABI_BUILTINS_LIBRARY)
-    list(APPEND CMAKE_REQUIRED_LIBRARIES "${LIBCXXABI_BUILTINS_LIBRARY}")
+    set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${LIBCXXABI_BUILTINS_LIBRARY}")
   else ()
----------------
Similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109342/new/

https://reviews.llvm.org/D109342