[libcxx-commits] [PATCH] D109286: [libc++][NFC] Test span is nothrow trivially destructible

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/containers/views/span.cons/span.dtor.pass.cpp:23
+
+int main(int, char**) {
+  testDestructor<std::span<int, 1> >();
----------------
Since the test doesn't execute any code, please rename the file to `span.dtor.compile.pass.cpp` and rename `main` to a different name, `test` for example.

The types of test files used is documented in `utils/libcxx/test/format.py`
```
    Lit test format for the C++ Standard Library conformance test suite.        

    This test format is based on top of the ShTest format -- it basically       
    creates a shell script performing the right operations (compile/link/run)   
    based on the extension of the test file it encounters. It supports files    
    with the following extensions:                                              

    FOO.pass.cpp            - Compiles, links and runs successfully             
    FOO.pass.mm             - Same as .pass.cpp, but for Objective-C++          

    FOO.compile.pass.cpp    - Compiles successfully, link and run not attempted 
    FOO.compile.fail.cpp    - Does not compile successfully                     
        
    FOO.link.pass.cpp       - Compiles and links successfully, run not attempted
    FOO.link.fail.cpp       - Compiles successfully, but fails to link          
        
    FOO.sh.<anything>       - A builtin Lit Shell test
    
    FOO.verify.cpp          - Compiles with clang-verify. This type of test is  
                              automatically marked as UNSUPPORTED if the compiler
                              does not support Clang-verify.
    
    FOO.fail.cpp            - Compiled with clang-verify if clang-verify is     
                              supported, and equivalent to a .compile.fail.cpp  
                              test otherwise. This is supported only for backwards
                              compatibility with the test suite.

```


================
Comment at: libcxx/test/std/containers/views/span.cons/span.dtor.pass.cpp:25
+  testDestructor<std::span<int, 1> >();
+  testDestructor<std::span<int> >();
+
----------------
Can you please remove the unneeded space `> >`?
Once llvm 13 is released we can use its clang-format which doesn't add the unneeded spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109286/new/

https://reviews.llvm.org/D109286