[libcxx-commits] [PATCH] D96664: [libc++][format] Implement formatters.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.functions/tests.inc:1
+//===----------------------------------------------------------------------===//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
----------------
ldionne wrote:
> Mordante wrote:
> > This file is obsolete and should be removed. I prefer to keep this file a little bit longer. This will make it a lot easier to migrate the other patches in the series to the new `format_tests.h`. Once that migration is done this file can be removed.
> It's very unusual to approve patches with these sorts of artifacts, let's make this an exception.
Thanks. That really helped to migrate the other patches to the new `format_tests.h` without introducing merge conflicts in the process.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96664/new/

https://reviews.llvm.org/D96664