[libcxx-commits] [PATCH] D109066: [libc++] Implement P1951, default arguments for pair's forwarding constructor

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D109066#2983072 <https://reviews.llvm.org/D109066#2983072>, @ldionne wrote:

> In D109066#2982889 <https://reviews.llvm.org/D109066#2982889>, @Quuxplusone wrote:
>
>> (Mild surprise that we're backporting this still-only-tentatively-C++23 change all the way back to C++11, but I have no better suggestion.)
>
> Yeah.. I thought about doing it strictly like I always fight for, however in this case this seems to be closer to a DR than anything else. I mean the code previously would work just as well, but it would make a copy instead by using the `pair(T1 const&, T2 const&)` ctor. So IMO this is in essence closer to a LWG issue being fixed than an actual feature.

Actually I was surprised it wasn't a LWG issue. I didn't question the back-porting since I agree this is a good exception of our rule.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109066/new/

https://reviews.llvm.org/D109066