[libcxx-commits] [PATCH] D108343: [NFC][libcxxabi] Refactor libcxxabi/src/cxa_guard_impl.h

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Sorry for the delay.

As you mention, this change is kind of large to review as-is. If you can split it into a few changes that are easier to review, it would be helpful. As it stands, it's difficult for me to validate that this is good since I don't know the code by heart and there's several unrelated changes bunched together.

It would also be awesome if you could put up for review the subsequent change that this will all be useful for (although I understand you might not be allowed to yet).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108343/new/

https://reviews.llvm.org/D108343