[libcxx-commits] [PATCH] D109066: [libc++] Implement P1951, default arguments for pair's forwarding constructor

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Looks like some GCC/Clang implementation divergence in re `explicit_vs_implicit_brace_init({{}, {}})`. I don't know who's correct.
Anyway, LGTM.

(Mild surprise that we're backporting this still-only-tentatively-C++23 change all the way back to C++11, but I have no better suggestion.)



================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.pair/U_V.pass.cpp:140
+        {
+            std::pair<BraceInit, BraceInit> p{{}, {}}; (void)p;
+        }
----------------
`(void)p;` on its own line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109066/new/

https://reviews.llvm.org/D109066