[libcxx-commits] [PATCH] D109204: [libc++][NFC] Mark values in gdb pretty print comparison functions as live to prevent values being optimized out.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Cherry-picked onto `release/13.x` as

  commit 1c3fcc8ae92ebfe9a9d1a21a288ad71ef7f98091 (HEAD -> release/13.x)
  Author: Amy Kwan <amy.kwan1 at ibm.com>
  Date:   Fri Sep 3 14:53:57 2021 -0400
  
      [libc++][NFC] Mark values in gdb pretty print comparison functions as live to prevent values being optimized out.
  
      It appears when testing LLVM 13 on Power, we run into failures with the
      `libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp` test case optimizing
      values out.
  
      Despite some the functions in the test already being marked with optnone,
      adding the `MarkAsLive()` calls inside of the pretty printer comparison functions
      resolves the issues of the values being optimized out.
  
      This patch aims to address https://llvm.org/PR51675.
  
      Differential Revision: https://reviews.llvm.org/D109204
  
      (cherry picked from commit 217c6d643124be312f4a99b203118744edb9d54c)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109204/new/

https://reviews.llvm.org/D109204