[libcxx-commits] [PATCH] D109075: [libc++][NFC] Move concepts to a subheader.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/include/__concepts/arithmetic.h:43-44
+concept __libcpp_signed_integer = __libcpp_is_signed_integer<_Tp>::value;
+template <class _Tp>
+concept __libcpp_floating_point = __libcpp_is_floating_point<_Tp>::value;
+
----------------
Quuxplusone wrote:
> `__libcpp_floating_point` is completely unused, as is `__libcpp_is_floating_point`. I believe you should just remove those.
> Anyone who wants to know whether a type is float/double/long-double should just use the standard `std::is_floating_point` trait or `std::floating_point` concept. We have no reason to provide a separate version of our own.
I added it for consistency, but I don't feel strongly about this concept. I don't like to do that change in this patch. I'll do this in a separate commit.


================
Comment at: libcxx/include/type_traits:792-793
 
 // __libcpp_is_signed_integer, __libcpp_is_unsigned_integer
-// <concepts> implements __libcpp_signed_integer, __libcpp_unsigned_integer
+// <__concepts/arithmetic.h> implements __libcpp_signed_integer, __libcpp_unsigned_integer
 
----------------
Quuxplusone wrote:
> This comment seems no longer useful. Just remove lines 792-794.
Good catch, must have happened when rebasing the original patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109075/new/

https://reviews.llvm.org/D109075