[libcxx-commits] [PATCH] D107835: [libunwind] Compile with -Wunused-but-set-variable

[Daniel Kiss via Phabricator via libcxx-commits]

danielkiss added a comment.

> introducing code that has set-but-unused variables

This what I mean, code is unused variable free and the flag helps to stay as it is.

> increases maintenance burden and developer flexibility when moving between subprojects.

I hope this flag is not so harmful nor problematic for new code.

> I support that llvm/cmake/modules/HandleLLVMOptions.cmake adds -Wunused-but-set-variable as well, after some cleanup.

Sounds good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107835/new/

https://reviews.llvm.org/D107835