[libcxx-commits] [PATCH] D108216: [libc++] Formulate _EnableIf in terms of std::enable_if

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

So, on the one hand, I see a noticeable improvement on diagnostics.

On the other hand, I see a potential for a slight compile-time degradation which, while I 100% agree with in theory, I don't have a clear sense of how bad it is.

I think I can argue that with the current evidence, this patch should land, so I'm going to do that unless someone has additional concerns. I'm leaving this patch open for 24hrs to get comments from folks (ping @EricWF in particular), then I'm landing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108216/new/

https://reviews.llvm.org/D108216