[libcxx-commits] [PATCH] D110497: [libc++][format][3/6] Adds a __container_buffer.

[Victor Zverovich via Phabricator via libcxx-commits]

vitaut added a comment.

> Since there's no guarantee every container's insert behaves properly

What does behaving properly mean? Could you give an example of a container's insert that doesn't behave properly?



================
Comment at: libcxx/include/__format/buffer.h:92
+/// The concept is used to validate whether multiple calls to a
+/// \ref back_insert_iterator can be replace by a call to \c _Container::insert.
+///
----------------
replace -> replaced


================
Comment at: libcxx/include/__format/buffer.h:94
+///
+/// \note a \a _Container needs to opt-in to the concept by adding a typedef
+/// \ref __enable_format_insertable with the same type as \a _Container.
----------------
opt-in to -> "opt in to" or "opt into"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110497/new/

https://reviews.llvm.org/D110497