[libcxx-commits] [PATCH] D112836: [libc++] Transparent unordered_foo::count() should use __count_multi.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 29 12:28:57 PDT 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

> N.B.: I just copied the existing count_transparent.pass.cpp from set... but that gives us both Marshall's count_transparent.pass.cpp and Ruslan's count.transparent.pass.cpp. This is probably a terrible idea, so I'm open to suggestions for new test names.

Can we rename all `count_transparent.pass.cpp` tests to `count.transparent.pass.cpp`, and merge the ones you are adding for the unordered containers with the ones that already exist (Ruslan's)?

FWIW I'm fine with this as-is once we figure out the naming of tests.



================
Comment at: libcxx/test/std/containers/associative/set/equal_range_transparent.pass.cpp:16-20
 //     pair<iterator,iterator>             equal_range(const K& x);        //
 //     C++14
 // template<typename K>
 //     pair<const_iterator,const_iterator> equal_range(const K& x) const;  //
 //     C++14
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112836/new/

https://reviews.llvm.org/D112836



More information about the libcxx-commits mailing list