[libcxx-commits] [PATCH] D110994: [libc++] Make test_allocator constexpr-friendly for constexpr string/vector

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 28 13:39:07 PDT 2021


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/containers/associative/map/map.cons/assign_initializer_list.pass.cpp:24
 
+test_allocator_statistics alloc_stats;
+
----------------
ldionne wrote:
> While we're at it, can we avoid making these allocation stats global? We could define the stats as local variables in the functions.
Gentle ping on this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110994/new/

https://reviews.llvm.org/D110994



More information about the libcxx-commits mailing list