[libcxx-commits] [PATCH] D112553: [libc++] Make is_error_condition_enum_v and is_error_code_enum_v bool, not size_t

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

It is technically an ABI break, but I literally can't imagine someone being bitten by it -- perhaps I'm not imaginative enough? One would have to basically have a data member or function parameter of type `decltype(is_error_condition_enum_v<...>)`, or something along those lines. Given the name of the utility, which starts with `is_`, everybody has probably been using it correctly, i.e. as a compile-time boolean and nothing else. IMO not fixing that bug based on ABI break concerns would be unreasonable. I'll take the responsibility for it if things turn sour :-). Let's add a release note and call it a day.

Regarding adding visibility/linkage annotations to those variable templates -- I wouldn't do it, I think we'll want to find a solution to treat all the variable templates consistently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112553/new/

https://reviews.llvm.org/D112553