[libcxx-commits] [PATCH] D112737: [libc++] Temporarily mark tests as UNSUPPORTED to get the CI green

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 28 11:15:34 PDT 2021


Mordante added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp:17
+// TEMPORARY TO GET THE CI GREEN
+// UNSUPPORTED: *
+
----------------
jloser wrote:
> Can we just `XFAIL` them for `gcc11` instead for now? Ditto for the other uses.
Normally I agree with this sentiment. But my change accidentally broke the entire CI. So I prefer this work-around and then fix it properly afterwards. That way we can keep using our CI while we sort the fallout later.

It seems updating the Dockerfile in a commit doesn't cause the CI to use these changes.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112737/new/

https://reviews.llvm.org/D112737



More information about the libcxx-commits mailing list