[libcxx-commits] [PATCH] D111359: [libc++][CI] Add AIX pipeline config

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This looks fine to me -- welcome to the family.

Can you please rebase onto `main` so we get a clean CI run? I'd like to keep the CI red for everyone. It will also allow us to assess the latency for CI on AIX and make sure it's not going to cause problems.



================
Comment at: libcxx/docs/index.rst:108
 AppleClang   12                                         latest stable release per `Xcode's release page <https://developer.apple.com/documentation/xcode-release-notes>`_
+Open XL      17.1 (AIX)                                 latest stable release per `Open XL's documentation page <https://www.ibm.com/docs/en/openxl-c-and-cpp-aix>`_
 GCC          11              In C++11 or later only     latest stable release per `GCC's release page <https://gcc.gnu.org/releases.html>`_
----------------
daltenty wrote:
> ldionne wrote:
> > Now that is a much larger commitment. What is Open XL? Is it based on Clang? If so, what the relationship with Clang?
> > 
> > I'm asking because we are just starting to get out of the weeds with our compiler support and moving on to more recent compilers. The last thing I want is tie our hands again supporting some compiler that we don't have control over. I thought you folks were using Clang.
> > 
> > What is the release cycle for Open XL like?
> > 
> > Sorry for all those questions, but I want to figure out what this commitment would involve before we make it officially. I want to move out of the "hand wavy support" realm and into "we say we support it therefore we DO support it". But that makes the commitment much more serious, and so I'd like to understand the parameters of it.
> I definitely understand the concern, hopefully I can clarify a bit.
> 
> > What is Open XL? Is it based on Clang? If so, what the relationship with Clang?
> 
> IBM XL Compilers completed the adoption of Clang/LLVM and just released 17.1,  which is rebranded to Open XL Compilers. This release is based on LLVM 13.
> 
> >  I thought you folks were using Clang.
> 
> We probably need to use Open XL 17.1 as a build compiler for now on AIX because a stable LLVM release which includes all required AIX support hasn't been released yet.
> 
> > What is the release cycle for Open XL like?
> 
> IBM has been further investing in LLVM and made commitments to AIX support.  Although we won't be able to expose the detailed release schedule, we tend to regularly deliver new releases of Open XL to pick up new stuff and enhancements from the community.


> IBM has been further investing in LLVM and made commitments to AIX support. Although we won't be able to expose the detailed release schedule, we tend to regularly deliver new releases of Open XL to pick up new stuff and enhancements from the community.

Okay, got it. As long as there's an intent to regularly update the compiler, I'm fine with that. Basically, I want to make sure that we don't start having a bunch of OpenXL specific hacks in the code base to support that compiler just because our documentation says we do. As long as we don't have to bend backwards to support it, I think it's all good. Note that I have the same attitude towards Apple's own compiler -- I've removed support for all but the latest AppleClang in order to simplify things, and if we suddenly stopped updating our compiler, it would be reasonable for the project to stop supporting it. Fortunately that's not going to happen, but I just want to stress that these measures aim to protect the health of the project and let us keep a decent development velocity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111359/new/

https://reviews.llvm.org/D111359